Let mopidy mute at app-level the audio #512
Conversation
|
Have you seen this pulseaudio bug https://bugzilla.gnome.org/show_bug.cgi?id=672401? I don't use pulseaudio myself but I don't think the fixed version of gstreamer0.10-plugins-good (0.10.32) has made it to the debian package repos etc yet. Just something to maybe watch out for. |
|
Yeah, sharp stuff to care about... Need to research further about it thought |
|
Fixup the test failures, and the non-software mixer cases and this is ready to go in. |
| @@ -37,8 +39,9 @@ def outputs(context): | |||
|
|
|||
| Shows information about all outputs. | |||
| """ | |||
| ena = 0 if context.core.playback.get_mute().get() else 1 | |||
There was a problem hiding this comment.
Write the variable name out completely: enabled
|
I'd like some tests as well, on both the MPD and core part. The audio part is OK as is. |
| @@ -13,7 +13,8 @@ def disableoutput(context, outputid): | |||
|
|
|||
| Turns an output off. | |||
| """ | |||
| raise MpdNotImplemented # TODO | |||
| if int(outputid) == 0: | |||
There was a problem hiding this comment.
Is outputid really always 0? (I've no idea, just seems odd).
EDIT: Yes it seems it is (because we now only support one output, I'm guessing).
There was a problem hiding this comment.
Well, I just took 0 as reference because it is hardcoded up there, so I just suppose that 0 is correct. A future implementation with several outputs should be changing this. Now atm is valid.
|
@jodal I have finally done nearly all the changes, still needed:
I am sorry to say that about the tests, I have no time atm for them, so I would truly appreciate if someone could make some, else, this will take some time on the future. |
|
This is small enough that I'm willing to add the tests myself just to get it merged :-) |
|
Don't contain yourself! I have 5 hours of class now... |
ghost
assigned
|
I have been reviewing the code, and I didn't do the app/mixer differentiation because I don't know how to do mixer level mute! Anyway, I will push now one commit preparing it |
|
See #512 (comment) and #512 (comment) |
|
s/adam/thomas/ Adamcik is a last name, a lot of people seem to be mixing this up lately. :-) |
|
I've now posted a new PR #529 that polishes this PR into something that should be mergeable. |
|
Closing in favour of jodal's PR which wraps up the missing tests etc. |
|
Merging #529 would eventually have closed this one as well, as its a strict superset of this PR :-) |
Create a playback interface to mute the music (maintaining before volume), doing it at app level (not system-wide). Also created the mpd binding, by using the default audio output as the main audio output.