Core playback and tracklist modularity improvement v2 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 7, 2013 10:44
…k and moved those functions to TracklistController, which may control all related to the tracks. Updated tests too.
…to have information of, /mopidy/frontends/mpd/protocol/status.py@189 should be checked for gathering a value before the rest.
… to be given as an argument
…ment. Rewrote tests too.
…t be consumed or not
…lows to mark songs as consumed (that have been played full time), played (that have been played for some time) and unplayable
docs: Updated changelog.rst
Git was not correctly identifying the merge and threw a conflict
…ssing it. The failure was invisible to testcases
…ontroller to tracklist for test uniformity
To make the type of the variable obvious
tracklist.tl_tracks is always a list
The test was modified to not fail after a refactoring, making it not test what it was intended to test at all. This reverts the changes and updates the test in another way, keeping the original intention.
adamcik
added a commit
that referenced
this pull request
Oct 19, 2013
Core playback and tracklist modularity improvement v2
|
Very great job @adamcik |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds upon pull request #491 to fix the outstanding issues and bring it to a mergeable state.