scanner: Switch to gst.pbutils.Discoverer and refactor API #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New API wraps gst.pbutils.Discoverer for mopidy use. - Custom scanner code removed. - Callback based async API switched with simpler synchronous API - Scanner is feed one and one URI and returns the result or raises an error. - Adds new ScannerError exception for error handling in scanner - Limits local/scan_timeout to 1000-3600000 i.e. 1s to 1h - Files with zero duration are now excluded. - Mtime handling moved out of scanner so we can use it for streams etc.
|
|
||
| from mopidy import config as config_lib, ext | ||
| from mopidy import config as config_lib, ext, exceptions |
- Move ScannerError to exceptions module. - Subclass ScannerError from MopidyException. - Fix import sorting.
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| import unittest | |||
|
|
|||
| from mopidy import exceptions | |||
| from mopidy.scanner import Scanner, translator | |||
There was a problem hiding this comment.
Sort imports :-)
(moved comment from commit to PR)
jodal
added a commit
that referenced
this pull request
Oct 20, 2013
scanner: Switch to gst.pbutils.Discoverer and refactor API
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes slowest tests found in #534 and paves the way for making the stream backend lookup metadata.