audio: Cleanup scanner code and support live sources #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make attributes internal with _ naming - Cleanup handling of min durtion. Min set to None disables the check. - Check state change result for no preroll which indicates a live source which must transistion to playing to get tags etc.
jodal
added a commit
that referenced
this pull request
Dec 4, 2013
audio: Cleanup scanner code and support live sources
|
Would it be trivial to support the case of moving the tracks between scans? Seems like what I said in IRC about it only happening during a live scan is not true - see #596 |
|
This has nothing to do with that case :-) I'll followup more on the other bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must transistion to playing to get tags etc.