This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Update installation.rst (Instructions for OS X) #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `sudo` on creating a libspotify symlink since /usr/local is user-accessible. Adds `brew install libffi` since it's required to compile pyspotify.
| Install libffi as a dependency:: | ||
|
|
||
| brew install libffi | ||
|
|
There was a problem hiding this comment.
First, libffi is provided by OS X by default. The Homebrew formula for libffi is "keg-only". Do you know for a fact that the libffi bundled with OS X isn't good enough?
Second, instructions about libffi, which is a cffi/pyspotify dep, should not be in the middle of the libspotify section.
There was a problem hiding this comment.
Fair enough, I'm very sorry for the hasty pull request. I'll create an issue later instead. libffi is indeed provided by OS X, I had some weird error and don't have the logs at hand. Sorry for the inconvenience.
|
OK, thanks for the confirmation. I removed the unnecessary |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
sudoon creating a libspotify symlink since /usr/local is user-accessible.Adds
brew install libffisince it's required to compile pyspotify.