Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements Requirements Requirements #90

Merged
merged 17 commits into from
Mar 13, 2023
Merged

Requirements Requirements Requirements #90

merged 17 commits into from
Mar 13, 2023

Conversation

fiestajetsam
Copy link
Collaborator

This is the start (and bulk) of the requirements being put onto the table. Lot of commit messages provide context and justification as to why. Further commits will be added in the coming days, but earlier feedback would be appreciated.

This includes a section rename. I think this needs to eventually be covered
within the working group, as I foresee analysis of the security and trust models
that may arise from later work describe this as something that is required - in
existing protocols we have fairly primitive things in place - RTMP has access
keys, HTTP based protocols use a wide variety of methods.
I'm not sure consensus has been finalised about which means of encapsulation
should be required; for now saying that if the WG is going to use an existing
format, we should have agility within the protocol.
I think a better way of proposing this issue is one of a trade-off between
guarantee of delivery, and of delay as receivers may drop stuff and not use
media if it either never arrives or because it arrived too late. This kind of
phrasing should also clear up a discussion around "stream vs datagram" because
the requirements defined here wil largely determine what types are used -
streams for reliable in order, datagram for lossy out-of-order.
This has been moved up since it applies to both producing and receiving.
@SpencerDawkins SpencerDawkins self-requested a review March 10, 2023 19:57
Copy link
Collaborator

@SpencerDawkins SpencerDawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fiestajetsam - I had two or three nits, but on the whole, this looks eminently mergeable and submittable to me, as -04. Does it look that way to you?

draft-gruessing-moq-requirements.md Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Show resolved Hide resolved
This really can be addressed via authentication, and through the data model used
to represent media. This is further complicated by providers which may have
differing sales models.
Put as a higher level concept, but ties together hopefully a lot of other
discussions.
@fiestajetsam
Copy link
Collaborator Author

I've done enough clearing up, however there is a few points outstanding that need attention later. I'll leave this open a bit, if you get time to look at it later your feedback would be appreciated, otherwise I'll merge and push a new version out Monday.

Copy link
Collaborator

@SpencerDawkins SpencerDawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should be commenting, not "approving" or "requesting changes" - my apologies for being dense.

Also, Today I Learned how to make suggestions in GitHub reviews. 😱

I'll be more fun to collaborate with now.

draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
draft-gruessing-moq-requirements.md Outdated Show resolved Hide resolved
@fiestajetsam fiestajetsam merged commit e9fed71 into main Mar 13, 2023
@fiestajetsam fiestajetsam deleted the 116 branch March 13, 2023 17:09
Copy link

@tungmeoo tungmeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants