Skip to content

Commit

Permalink
Remove unneeded conditional compilation
Browse files Browse the repository at this point in the history
  • Loading branch information
stakx committed Jun 18, 2020
1 parent d3f18ad commit 2352750
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
7 changes: 0 additions & 7 deletions src/Moq/Moq.csproj
Expand Up @@ -38,13 +38,6 @@
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net45' ">
<DefineConstants>$(DefineConstants);FEATURE_CAS;FEATURE_COM</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<DefineConstants>$(DefineConstants)</DefineConstants>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Castle.Core" Version="4.4.0" />
<PackageReference Include="IFluentInterface" Version="2.1.0" PrivateAssets="All" />
Expand Down
4 changes: 0 additions & 4 deletions tests/Moq.Tests/ComCompatibilityFixture.cs
@@ -1,8 +1,6 @@
// Copyright (c) 2007, Clarius Consulting, Manas Technology Solutions, InSTEDD.
// All rights reserved. Licensed under the BSD 3-Clause License; see License.txt.

#if FEATURE_COM

using Moq.Tests.ComTypes;

using Xunit;
Expand Down Expand Up @@ -104,5 +102,3 @@ public void COM_interop_type_indexer_setter_is_recognized_as_such()
}
}
}

#endif
4 changes: 2 additions & 2 deletions tests/Moq.Tests/Moq.Tests.csproj
Expand Up @@ -15,7 +15,7 @@
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net472' ">
<DefineConstants>$(DefineConstants);FEATURE_CAS;FEATURE_DYNAMICPROXY_SERIALIZABLE_PROXIES;FEATURE_COM;FEATURE_EF;FEATURE_SYSTEM_WEB;FEATURE_SYSTEM_WINDOWS_FORMS</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_DYNAMICPROXY_SERIALIZABLE_PROXIES;FEATURE_EF;FEATURE_SYSTEM_WEB;FEATURE_SYSTEM_WINDOWS_FORMS</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
<DefineConstants>$(DefineConstants)</DefineConstants>
Expand All @@ -27,7 +27,7 @@
<ProjectReference Include="..\..\src\Moq\Moq.csproj" />
<ProjectReference Include="..\Moq.Tests.FSharpTypes\Moq.Tests.FSharpTypes.fsproj" />
</ItemGroup>
<ItemGroup Condition=" $([System.Text.RegularExpressions.Regex]::IsMatch('$(DefineConstants)', 'FEATURE_COM'))">
<ItemGroup>
<Reference Include="Moq.Tests.ComTypes">
<HintPath>..\Moq.Tests.ComTypes\Moq.Tests.ComTypes.dll</HintPath>
</Reference>
Expand Down

0 comments on commit 2352750

Please sign in to comment.