Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupSequence is missing for void methods #451

Closed
alexbestul opened this issue Sep 22, 2017 · 7 comments
Closed

SetupSequence is missing for void methods #451

alexbestul opened this issue Sep 22, 2017 · 7 comments
Milestone

Comments

@alexbestul
Copy link
Contributor

SetupSequence is cool, but only works for methods that produce a return value. Is there a reason that it's not supported for void methods? I'd like to have that support in order to test some exception-handling retry logic.

I've got a branch ready with Pass and Throws implemented. Those are the only useful methods I could think of.

Please let me know if you're interested, and I'll open a PR.

@alexbestul
Copy link
Contributor Author

Opened PR #454

@stakx
Copy link
Contributor

stakx commented Oct 1, 2017

Hi @alexbestul, thank you for your PR, and sorry for the delay. Currently trying to get some bug fixes through, but I will review your PR soon. (Just reviewed your PR now.) It sounds like a sensible and useful extension to Moq's API.

@stakx stakx added this to the v4.8.0 milestone Oct 1, 2017
alexbestul added a commit to alexbestul/moq4 that referenced this issue Oct 2, 2017
@stakx
Copy link
Contributor

stakx commented Oct 2, 2017

Merged. Thank you for this new feature! 👍

@stakx stakx closed this as completed Oct 2, 2017
@Adrian10988
Copy link

As of version 4.7.145 SetupSequence still complains about not providing a TResult

@stakx
Copy link
Contributor

stakx commented Nov 22, 2017

@Adrian10988: Not sure what you mean by that, is this related to this issue? If so, the answer is simply that the new feature hasn't been merged into master yet / is scheduled for version 4.8.0. If it's unrelated, please open a new issue.

@Adrian10988
Copy link

Yea I was noting that it still seemed to not be fixed. I thought I had seen it pushed to the current version. My mistake, and thank you for the reply.

@stakx
Copy link
Contributor

stakx commented Nov 23, 2017

You can always check the changelog for these kinds of questions. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants