Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use value argument in mock.Protected().SetupSet and ...VerifySet #1186

Merged
merged 2 commits into from Jul 22, 2021
Merged

Use value argument in mock.Protected().SetupSet and ...VerifySet #1186

merged 2 commits into from Jul 22, 2021

Conversation

tonyhallett
Copy link
Contributor

@tonyhallett tonyhallett commented Jul 20, 2021 •
edited by stakx

Fixes #1184.

@stakx stakx changed the title fix #1184 Use value argument in mock.Protected().SetupSet and ...VerifySet Jul 21, 2021
stakx
stakx suggested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Please add a changelog entry for this bug fix, then this should be ready for merging.

@stakx stakx mentioned this pull request Jul 22, 2021
Closed
@stakx stakx added this to the 4.16.2 milestone Jul 22, 2021
@stakx stakx merged commit 8fa13f4 into devlooped:main Jul 22, 2021
@stakx stakx mentioned this pull request Aug 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakx stakx stakx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

Parameter is invalid in Protected().SetupSet() method
2 participants
@tonyhallett @stakx