Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actual invocation formatting to show the values for reference… #304

Conversation

apollo2030
Copy link

When using verify to check for a specific invocation, the failure message was listing invocations of the method with the arguments using the objects ToString() method. The default implementation of the ToString() is to provide the full name which for more complex types is not very usefull - we a re more interested in the values of the properties of the complex type arguments.

@kzu
Copy link
Contributor

kzu commented Nov 29, 2016

What if you have provided ToString override just for this purpose?

@apollo2030
Copy link
Author

I would have to do that for all the types the complex type consist of. Doing it here will prevent adding code to the types just for testing.

@stakx
Copy link
Contributor

stakx commented Jun 3, 2017

See also issue #84.

@stakx
Copy link
Contributor

stakx commented Sep 21, 2017

@apollo2030, I am closing this PR. The idea behind your proposal is a good one, but as per the comments above, this solution is too specific; a more generic mechanism / extension point would be preferable.

Thank you nevertheless for taking the time to prepare this! Perhaps we can base further work / discussion done on #84 on it so that your effort isn't completely lost!

@stakx stakx closed this Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants