Make event accessor recognition logic more correct #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Jun 15, 2017
| @@ -61,12 +61,12 @@ public static bool IsDestructor(this MethodInfo method) | |||
| } | |||
|
|
|||
|
|
|||
| public static bool IsEventAttach(this MethodBase method) | |||
| public static bool LooksLikeEventAttach(this MethodBase method) | |||
There was a problem hiding this comment.
Let's be honest and call it what it really does.
Up until now, if Moq encounters a method named `add_X` or `remove_X` it will assume that it's found an specialname event accessor method without performing any further checks. This commits adds some trivial type checks and null reference checks to improve that logic somewhat. I hesitate to make this too perfect since that just might break things for F# or COM (see commit 44070a9).
stakx
force-pushed
the
event-accessor-recognition
branch
from
234d19c
to
63750bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, if Moq encounters a method named
add_Xorremove_Xit will assume that it's found an specialname event accessor method without performing any further checks.This commits adds some trivial type checks and null reference checks to improve that logic somewhat. I hesitate to make this too perfect since that just might break things for F# or COM (see commit 44070a9).
This partially fixes #82.