Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output Map of org.moqui.impl.EmailServices.send#EmailTemplate is not correct #107

Closed
locnguyenx opened this issue Sep 9, 2016 · 1 comment

Comments

@locnguyenx
Copy link

the service interface org.moqui.EmailServices.send#EmailTemplate has following out-parameters

<out-parameters>
            <parameter name="messageId"><description>From the Message-ID email header field.</description></parameter>
            <parameter name="emailMessageId"><description>If createEmailMessage=true the ID of the EmailMessage record.</description></parameter>
        </out-parameters>

In service implementation (org.moqui.impl.EmailServices.send#EmailTemplate), script "sendEmailTemplate.groovy" has last statement as following if email is sent sucessfully:

ec.service.sync().name("update", "moqui.basic.email.EmailMessage").parameters(uemParms).disableAuthz().call()

This will cause service's output Map is the result of this Entity Auto service, which is [oldStatusId, statusChanged].

We must put one more line after this statement to return null, so that correct output Map will be built

@jonesde
Copy link
Member

jonesde commented Sep 9, 2016

Thank you, this is fixed in commit #272e499.

@jonesde jonesde closed this as completed Sep 9, 2016
acetousk pushed a commit that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants