Docker-Image-Pull Feature #553

rohitpawar2811 · 2022-11-08T06:16:54Z

I have created the Docker-Image-Pull feature in which on clicking the INIT button it will fetch the Docker image mentioned according to credentials and also init Initialise instance in Async,by refresh you can check the status.

Changes have been verified for : AWS ,Docker-Hub ,Azure Registry
And Registry-Location: it contains the Registry-server-address now.
In the case of Aws-Ecr registry in the password we have to give cmd(aws ecr get-login-password --region us-east-1) for generating token and on the host system must aws configured by access id and secret key

Updated Changes :

suggested by @dixitdeepak : Created a field named authTokenCmd into moqui.server.instance.InstanceImage and then we can check based on that if authTokenCmd is not empty then go for that, otherwise use the password for authentication, From this way we can make it more generic and other registries like aws (which generates tokens different each time by using cmd) can easily be configured.

EX-:

Docker-Hub : https://index.docker.io/v1/
AWS-ECR-registry-server-address :[https://118728153888.dkr.ecr.us-east-1.amazonaws.com/v2/]
AZURE -REGISTRY -: rohitmkj.azurecr.io

… which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub

rohitpawar2811 · 2022-11-08T06:42:48Z

Docker-Images-Pulling-Instructions -: For configuring images ,whose instance we have to create and firstly we have to configure credentials ,from where we have to fetch/pull images.
-And after following things just create an instance and select the image , which you have created.
configuration point for image and registry in moqui.server.instance.InstanceImage
Instance-Image-Id : Must-be-unique-name/PK your choice
Image-Type-ID -: it's our choice of categorization
Host-Type-Id -: it's our choice of categorization
Image-Name - full-name of image must be given serveraddress/image-name:tag
EX-:

Aws : 118728153888.dkr.ecr.us-east-1.amazonaws.com/tk
Azure : rohitmkj.azurecr.io/moquil
Docker-Hub :- rohitroax123/moquil:latest
Docker-container-Private-registry : localhost:5000/moquil:latest

Registry-Location : it contains the Registry-server-address now.

Docker-container-private-registry : http://localhost:5000/v2/
Docker-Hub : https://index.docker.io/v1/
AWS-ECR-registry-server-address :[https://118728153888.dkr.ecr.us-east-1.amazonaws.com/v2/]
AZURE -REGISTRY -: rohitmkj.azurecr.io

Username : Name of user from which we can login to docker .
Password : password/ command(aws ecr get-login-password --region us-east-1) in case of Aws (through which token is generated)

jonesde · 2023-02-22T23:10:07Z

I apologize for the long delay reviewing this. The changes look good so there is just one thing missing: adding yourself to the AUTHORS file to take more formal credit for your changes, and to grant others clear permission to use them.

There are 2 sections in the AUTHORS file to sign by adding your legal name and github username like the others, and it must be a commit from the named GitHub account. There is one section for the CC0 license and one for the patent disclaimer in addition to the copyright disclaimer for CC0.

dixitdeepak · 2023-02-28T07:25:59Z

framework/service/org/moqui/impl/InstanceServices.xml

@@ -348,6 +359,42 @@ along with this software (see the LICENSE.md file). If not, see
            ec.logger.info("Initializing docker container for ${appInstance.instanceName} with:\n${jsonBody}")
            restClient.jsonObject(jsonBody)

+            try {
+                authToken = instanceImage.password
+                if (((String) instanceImage.username).equals("AWS")) {


@rohitpawar2811
Instead of having check on userName, we can extend InstanceImage entity to store the processCommand

Yes @dixitdeepak you are right I think we can go on this way :
we can create a field named authTokenCmd into moqui.server.instance.InstanceImage and then we can check based on that if authTokenCmd is not empty then go for that , otherwise use password for authentication, From this way we can make it more generic and other registries like aws (which generate token different by using cmd) can easily configured.

…d(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable

rohitpawar2811 · 2023-02-28T12:38:35Z

@dixitdeepak I have revised the changes as you suggested to me, thank you for suggestions.

rohitpawar2811 · 2023-03-01T05:59:08Z

I apologize for the long delay reviewing this. The changes look good so there is just one thing missing: adding yourself to the AUTHORS file to take more formal credit for your changes, and to grant others clear permission to use them.

There are 2 sections in the AUTHORS file to sign by adding your legal name and github username like the others, and it must be a commit from the named GitHub account. There is one section for the CC0 license and one for the patent disclaimer in addition to the copyright disclaimer for CC0.

@jonesde I have added Authors file as you said ,Thank you!

rohitpawar2811 · 2023-05-17T11:02:48Z

@jonesde Anything wrong with my changes?

acetousk · 2023-07-23T03:17:23Z

framework/entity/ServerEntities.xml

@@ -196,6 +196,7 @@ along with this software (see the LICENSE.md file). If not, see
        <field name="username" type="text-short"/>
        <field name="password" type="text-medium" encrypt="true"/>
        <field name="emailAddress" type="text-medium"/>
+        <field name ="authTokenCmd" type="text-medium"/>


Please add a description to authTokenCmd and remove the extra space there

Added description to authTokenCmd.
Removed the extra space.
Thanks for pointing it out!

You're welcome!

acetousk · 2023-07-23T03:19:26Z

framework/service/org/moqui/impl/InstanceServices.xml

+            <script><![CDATA[
+            import org.moqui.context.ExecutionContext
+            import java.util.concurrent.Future
+            Future<Map> instanceFuture = ec.service.async().name("${hostType.initService}").parameters([context:context,appInstanceId:appInstanceId]).callFuture()


What's the point of having calling this service async?

@acetousk
The point of making this service async is to prevent user/client from getting stuck when the image is not available. In synchronous calls, the user would have to wait for the image to be pulled, which could take 6-8 minutes depending on the size. By using asynchronous calls, the user can request to start the container, and if the image is not available, it will be automatically pulled in the background while the user can continue with other tasks. This improves user experience and efficiency.

* Fix regression with partitioned tables in PostgreSQL PostgreSQL JDBC Driver introduced separating type for partitioned table from 40.2.12 pgjdbc/pgjdbc#1708 * Add subscreensItem.menuInclude to menu data (moqui#600) * Fixed the problem that moqui cannot be deployed as non-root webapp in Tomcat * Fixed a runtime error if Currency is BTC * Fixed a runtime error if Currency is BTC * Fixed the retries of Elastic Client * Add subscreensItem.menuInclude to menu data * Docker-Image-Pull Feature (moqui#553) * Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub * Update AUTHORS * Added: added the generic way to process cmd , by adding an extra field(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable * Update ServerEntities.xml by adding description * Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details * In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object * In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch * Add text-area.@autogrow attribute, supported only in qvt for now * Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 * In build.gradle gitStatusAll task also handle upstream remotes with no master branch * Currency (moqui#614) * Use moqui.basic.Uom entity to determine currency formatting and rounding details * Add currency-hide-symbol attribute as a complement to currency-unit-field, displaying the value without the currency symbol * Update authors file * Add and Handle Hmac Sha256 with timestamp * A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) * In EntityAutoServiceRunner, remove unwanted break statement to ensure support for multiple PK fields with wildcard (*). * In ContextJavaUtil, add missing future keyword. * Updated authors file. * Allow for 10 second threshold in nowTimestamp * In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings * In addons.xml, added new moqui-sso component. --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com>

* Fix regression with partitioned tables in PostgreSQL PostgreSQL JDBC Driver introduced separating type for partitioned table from 40.2.12 pgjdbc/pgjdbc#1708 * Add subscreensItem.menuInclude to menu data (moqui#600) * Fixed the problem that moqui cannot be deployed as non-root webapp in Tomcat * Fixed a runtime error if Currency is BTC * Fixed a runtime error if Currency is BTC * Fixed the retries of Elastic Client * Add subscreensItem.menuInclude to menu data * Docker-Image-Pull Feature (moqui#553) * Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub * Update AUTHORS * Added: added the generic way to process cmd , by adding an extra field(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable * Update ServerEntities.xml by adding description * Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details * In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object * In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch * Add text-area.@autogrow attribute, supported only in qvt for now * Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 * In build.gradle gitStatusAll task also handle upstream remotes with no master branch * Currency (moqui#614) * Use moqui.basic.Uom entity to determine currency formatting and rounding details * Add currency-hide-symbol attribute as a complement to currency-unit-field, displaying the value without the currency symbol * Update authors file * Add and Handle Hmac Sha256 with timestamp * A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) * In EntityAutoServiceRunner, remove unwanted break statement to ensure support for multiple PK fields with wildcard (*). * In ContextJavaUtil, add missing future keyword. * Updated authors file. * Allow for 10 second threshold in nowTimestamp * In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings * In addons.xml, added new moqui-sso component. * Add AutoCloseable extension to EntityListIterator for use with try with resources, thanks to Deepak Dixit for the suggestion * BugFix EntityListIterator not closed in NotificationMessageImpl#getNotifyUserIds --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com>

* commit 'b4287f1b461398b3f22fe96cc9c9761b693a5c07': Change EntityDataWriterImpl to use groovy CompileStatic, without this a compile error was missed in the changes for PR moqui#625, fix small issues from this Implemented withCloseable/try-with-resources where needed in the code… (moqui#625) BugFix EntityListIterator not closed in NotificationMessageImpl#getNotifyUserIds Add AutoCloseable extension to EntityListIterator for use with try with resources, thanks to Deepak Dixit for the suggestion In addons.xml, added new moqui-sso component. In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings Allow for 10 second threshold in nowTimestamp A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) Add and Handle Hmac Sha256 with timestamp Currency (moqui#614) In build.gradle gitStatusAll task also handle upstream remotes with no master branch Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 Add text-area.@autogrow attribute, supported only in qvt for now In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details Docker-Image-Pull Feature (moqui#553) Add subscreensItem.menuInclude to menu data (moqui#600) Fix regression with partitioned tables in PostgreSQL

* Fix regression with partitioned tables in PostgreSQL PostgreSQL JDBC Driver introduced separating type for partitioned table from 40.2.12 pgjdbc/pgjdbc#1708 * Add subscreensItem.menuInclude to menu data (moqui#600) * Fixed the problem that moqui cannot be deployed as non-root webapp in Tomcat * Fixed a runtime error if Currency is BTC * Fixed a runtime error if Currency is BTC * Fixed the retries of Elastic Client * Add subscreensItem.menuInclude to menu data * Docker-Image-Pull Feature (moqui#553) * Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub * Update AUTHORS * Added: added the generic way to process cmd , by adding an extra field(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable * Update ServerEntities.xml by adding description * Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details * In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object * In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch * Add text-area.@autogrow attribute, supported only in qvt for now * Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 * In build.gradle gitStatusAll task also handle upstream remotes with no master branch * Currency (moqui#614) * Use moqui.basic.Uom entity to determine currency formatting and rounding details * Add currency-hide-symbol attribute as a complement to currency-unit-field, displaying the value without the currency symbol * Update authors file * Add and Handle Hmac Sha256 with timestamp * A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) * In EntityAutoServiceRunner, remove unwanted break statement to ensure support for multiple PK fields with wildcard (*). * In ContextJavaUtil, add missing future keyword. * Updated authors file. * Allow for 10 second threshold in nowTimestamp * In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings * In addons.xml, added new moqui-sso component. * Add AutoCloseable extension to EntityListIterator for use with try with resources, thanks to Deepak Dixit for the suggestion * BugFix EntityListIterator not closed in NotificationMessageImpl#getNotifyUserIds * Implemented withCloseable/try-with-resources where needed in the code… (moqui#625) * Implemented withCloseable/try-with-resources where needed in the code to ensure proper closure of the entity list iterator resource * Fixed withCloseable syntax --------- Co-authored-by: David E. Jones <dej@dejc.com> * Change EntityDataWriterImpl to use groovy CompileStatic, without this a compile error was missed in the changes for PR moqui#625, fix small issues from this --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com>

* Fix regression with partitioned tables in PostgreSQL PostgreSQL JDBC Driver introduced separating type for partitioned table from 40.2.12 pgjdbc/pgjdbc#1708 * Add subscreensItem.menuInclude to menu data (moqui#600) * Fixed the problem that moqui cannot be deployed as non-root webapp in Tomcat * Fixed a runtime error if Currency is BTC * Fixed a runtime error if Currency is BTC * Fixed the retries of Elastic Client * Add subscreensItem.menuInclude to menu data * Docker-Image-Pull Feature (moqui#553) * Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub * Update AUTHORS * Added: added the generic way to process cmd , by adding an extra field(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable * Update ServerEntities.xml by adding description * Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details * In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object * In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch * Add text-area.@autogrow attribute, supported only in qvt for now * Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 * In build.gradle gitStatusAll task also handle upstream remotes with no master branch * Currency (moqui#614) * Use moqui.basic.Uom entity to determine currency formatting and rounding details * Add currency-hide-symbol attribute as a complement to currency-unit-field, displaying the value without the currency symbol * Update authors file * Add and Handle Hmac Sha256 with timestamp * A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) * In EntityAutoServiceRunner, remove unwanted break statement to ensure support for multiple PK fields with wildcard (*). * In ContextJavaUtil, add missing future keyword. * Updated authors file. * Allow for 10 second threshold in nowTimestamp * In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings * In addons.xml, added new moqui-sso component. * Add AutoCloseable extension to EntityListIterator for use with try with resources, thanks to Deepak Dixit for the suggestion * BugFix EntityListIterator not closed in NotificationMessageImpl#getNotifyUserIds * Implemented withCloseable/try-with-resources where needed in the code… (moqui#625) * Implemented withCloseable/try-with-resources where needed in the code to ensure proper closure of the entity list iterator resource * Fixed withCloseable syntax --------- * Change EntityDataWriterImpl to use groovy CompileStatic, without this a compile error was missed in the changes for PR moqui#625, fix small issues from this --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com>

* Master (#11) (#12) * Fix regression with partitioned tables in PostgreSQL PostgreSQL JDBC Driver introduced separating type for partitioned table from 40.2.12 pgjdbc/pgjdbc#1708 * Add subscreensItem.menuInclude to menu data (moqui#600) * Fixed the problem that moqui cannot be deployed as non-root webapp in Tomcat * Fixed a runtime error if Currency is BTC * Fixed a runtime error if Currency is BTC * Fixed the retries of Elastic Client * Add subscreensItem.menuInclude to menu data * Docker-Image-Pull Feature (moqui#553) * Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub * Update AUTHORS * Added: added the generic way to process cmd , by adding an extra field(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable * Update ServerEntities.xml by adding description * Library updates, including Jetty 10.0.13 to 10.015 which had reported vulnerabilities; there are lots of dependencies updated in this set, see diff for full details * In ScreenRenderImpl change addFormFieldValue() and related methods to handle first, second, and last rows, for qvt and other client rendered output that needs full data for a form in a map/object * In root build.gradle change gitStatusAll task to be more tolerant of repos with no master branch * Add text-area.@autogrow attribute, supported only in qvt for now * Update various libraries including Groovy to 3.0.19 (which has some minor non-backward compatible changes single 3.0.10 with odd boolean behavior in rare cases, adjusted for in the framework long ago but should be watched for in custom code), Jetty to 10.0.16, H2 database, SLF4J, SnakeYAML, Apache Commons Lang3 * In build.gradle gitStatusAll task also handle upstream remotes with no master branch * Currency (moqui#614) * Use moqui.basic.Uom entity to determine currency formatting and rounding details * Add currency-hide-symbol attribute as a complement to currency-unit-field, displaying the value without the currency symbol * Update authors file * Add and Handle Hmac Sha256 with timestamp * A couple of minor bug fixes in the EntityAutoServiceRunner and ContextJavaUtil (moqui#618) * In EntityAutoServiceRunner, remove unwanted break statement to ensure support for multiple PK fields with wildcard (*). * In ContextJavaUtil, add missing future keyword. * Updated authors file. * Allow for 10 second threshold in nowTimestamp * In L10nFacadeImpl.formatCurrency() use disableAuthz() for entity find on Uom; small change to currency formatting test to pass with current OOTB settings * In addons.xml, added new moqui-sso component. * Add AutoCloseable extension to EntityListIterator for use with try with resources, thanks to Deepak Dixit for the suggestion * BugFix EntityListIterator not closed in NotificationMessageImpl#getNotifyUserIds * Implemented withCloseable/try-with-resources where needed in the code… (moqui#625) * Implemented withCloseable/try-with-resources where needed in the code to ensure proper closure of the entity list iterator resource * Fixed withCloseable syntax --------- * Change EntityDataWriterImpl to use groovy CompileStatic, without this a compile error was missed in the changes for PR moqui#625, fix small issues from this --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com> * Add sentDate field to WikiBlogCategory entity --------- Co-authored-by: Yao Chunlin <chunlinyao@gmail.com> Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: Wei Zhang <zhangw@shinetechsoftware.com> Co-authored-by: Rohit pawar <72196393+rohitpawar2811@users.noreply.github.com> Co-authored-by: Jens Hardings <jhp@moit.cl> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: Ayman Abi Abdallah <aabiabdallah@gmail.com>

Improvement: In Moqui-Multi-Instance added a Async-Pull-Image-Feature…

16df9e4

… which pulls the image by Using Docker-Engine-Api from multiple registry like AWS, Azure, Docker-Hub

dixitdeepak reviewed Feb 28, 2023

View reviewed changes

rohitpawar2811 and others added 3 commits February 28, 2023 13:11

Update AUTHORS

d6c07bf

Merge branch 'master' into DockerImagePullFeature

ca135ea

Added: added the generic way to process cmd , by adding an extra fiel…

a6427eb

…d(authTokenPass) inside the entity InstanceImage , now user has separate field for cmd and password so all types of registries is easily configurable

acetousk reviewed Jul 23, 2023

View reviewed changes

Update ServerEntities.xml by adding description

bc0e952

jonesde merged commit 86c3e0c into moqui:master Jul 26, 2023
1 check passed

dixitdeepak mentioned this pull request Dec 3, 2023

Master (#11) hotwax/moqui-framework#12

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker-Image-Pull Feature #553

Docker-Image-Pull Feature #553

rohitpawar2811 commented Nov 8, 2022 •

edited

rohitpawar2811 commented Nov 8, 2022 •

edited

jonesde commented Feb 22, 2023

dixitdeepak Feb 28, 2023

rohitpawar2811 Feb 28, 2023 •

edited

rohitpawar2811 commented Feb 28, 2023 •

edited

rohitpawar2811 commented Mar 1, 2023

rohitpawar2811 commented May 17, 2023 •

edited

acetousk Jul 23, 2023

rohitpawar2811 Jul 25, 2023

acetousk Jul 30, 2023

acetousk Jul 23, 2023

rohitpawar2811 Jul 25, 2023 •

edited

Docker-Image-Pull Feature #553

Docker-Image-Pull Feature #553

Conversation

rohitpawar2811 commented Nov 8, 2022 • edited

rohitpawar2811 commented Nov 8, 2022 • edited

jonesde commented Feb 22, 2023

dixitdeepak Feb 28, 2023

Choose a reason for hiding this comment

rohitpawar2811 Feb 28, 2023 • edited

Choose a reason for hiding this comment

rohitpawar2811 commented Feb 28, 2023 • edited

rohitpawar2811 commented Mar 1, 2023

rohitpawar2811 commented May 17, 2023 • edited

acetousk Jul 23, 2023

Choose a reason for hiding this comment

rohitpawar2811 Jul 25, 2023

Choose a reason for hiding this comment

acetousk Jul 30, 2023

Choose a reason for hiding this comment

acetousk Jul 23, 2023

Choose a reason for hiding this comment

rohitpawar2811 Jul 25, 2023 • edited

Choose a reason for hiding this comment

rohitpawar2811 commented Nov 8, 2022 •

edited

rohitpawar2811 commented Nov 8, 2022 •

edited

rohitpawar2811 Feb 28, 2023 •

edited

rohitpawar2811 commented Feb 28, 2023 •

edited

rohitpawar2811 commented May 17, 2023 •

edited

rohitpawar2811 Jul 25, 2023 •

edited