Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getNFTTrades responding with wrong data #138

Open
votrumar opened this issue Mar 4, 2022 · 0 comments
Open

getNFTTrades responding with wrong data #138

votrumar opened this issue Mar 4, 2022 · 0 comments

Comments

@votrumar
Copy link

votrumar commented Mar 4, 2022

Hi, I am fetching trades of particular collection using your API. Unfortunately the endpoint returns wrong data as there are token ids of other contracts than the one I am fetching. It happens in a case when there are more transfers in a single transaction.

For example when fetching transfers for azuki
https://deep-index.moralis.io/api/v2/nft/0xed5af388653567af2f388e6224dc7c4b3241c544/trades?from_block=14315470
one of the trades I receive is

{
            "transaction_hash": "0x4986a6c547cccdae5429604cd9d1ff7986fc98a3c727cba6a21652f5707d8273",
            "transaction_index": "58",
            "token_ids": [
                "10630",
                "10618",
                "10567",
                "10547",
                "10537",
                "10520",
                "10350",
                "10343",
                "10275",
                "10210",
                "10181",
                "10175",
                "10172",
                "10133",
                "13",
                "9258"
            ],
            "seller_address": "0x32ff21e4a2be3d0397933959e53e888ddf8df2f5",
            "buyer_address": "0x3109c5265cdeb23a806a7db74e59f476d7e5fd77",
            "token_address": "0xed5af388653567af2f388e6224dc7c4b3241c544",
            "marketplace_address": "0x7be8076f4ea4a4ad08075c2508e481d6c946d12b",
            "price": "700000000000000000",
            "price_token_address": null,
            "block_timestamp": "2022-03-03T18:49:43.000Z",
            "block_number": "14315762",
            "block_hash": "0xe1c00074037d944c8f4f322f6ec3648748739542006084504d871f5bd45b50db"
        },

however the Azuki collection has only 10000 tokens. Looking at the transaction the other token_ids are actually Parallel alpha. As there is no way how to distinguish which collection each of the token belongs to, this endpoint is useless....

I will be very glad if it gets fixed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant