Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Transferable not working for ERC-721 NFT Collection Module #146

Open
brother-ran opened this issue Mar 30, 2022 · 2 comments
Open

Non-Transferable not working for ERC-721 NFT Collection Module #146

brother-ran opened this issue Mar 30, 2022 · 2 comments

Comments

@brother-ran
Copy link

NFT tokens are still transferable by everyone even after we set contract to non-transferable successfully.

@brother-ran
Copy link
Author

Dig a little in to the contract code. Looks like it requires TRANSFER_ROLE to be revoked from the zero address to restrict the transfer. However, dashboard UI does not have the entrance to do that. It seems to me a bug of the new dashboard UI.

We manually interact with the contract to revoked the role and now it is correctly restricting the transfer.
https://mumbai.polygonscan.com/tx/0xfbc5a87d13ea13bccc461700e3c01511047eda2645c2847d2bc538d593fb5519
https://mumbai.polygonscan.com/tx/0xf993fc64272036604f11f921f9b0270f7a1ceed2eb7180ef9a76c905eea54339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant