Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: io blocking when downloading amazon images #924

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Fix IO blocking when downloading Amazon images

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the code-quality Improves code quality or adds/updates tests label Jun 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (8608d22) to head (e16a81f).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #924      +/-   ##
==========================================
- Coverage   95.07%   94.38%   -0.69%     
==========================================
  Files           8        8              
  Lines        1482     1532      +50     
==========================================
+ Hits         1409     1446      +37     
- Misses         73       86      +13     
Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)
custom_components/mail_and_packages/helpers.py 93.08% <100.00%> (-1.64%) ⬇️

... and 3 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review June 23, 2024 00:59
@firstof9 firstof9 merged commit 6076568 into moralmunky:dev Jun 23, 2024
5 checks passed
@firstof9 firstof9 deleted the more-io branch June 23, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants