Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-opening set_epymarl for linting #81

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Re-opening set_epymarl for linting #81

wants to merge 6 commits into from

Conversation

moratodpg
Copy link
Owner

No description provided.

@moratodpg moratodpg closed this Feb 21, 2024
@moratodpg moratodpg reopened this Feb 21, 2024
@PaLeroy
Copy link
Collaborator

PaLeroy commented Feb 22, 2024

Todo: change name from pymarl_wrapper to pymarl but this needs checks with the paper folder.

@moratodpg
Copy link
Owner Author

pymarl_wrapper modified now to pymarl in all files.

Copy link
Collaborator

@PaLeroy PaLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the pymarl folder in the README inside pymarl.
Everything is nice!

@@ -102,7 +102,7 @@ To test the agents at training time, you need to modify `run.sh` file.
To test the agents after training, use the `run_test.sh` file.

```bash
./pymarl_wrapper/run_test.sh experiment_name n_test_epsiode
./pymarl/run_test.sh experiment_name n_test_epsiode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we simply remove the pymarl folder here like for training a bit above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants