-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Random Image Support #1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
============================================
+ Coverage 85.71% 88.88% +3.17%
- Complexity 17 21 +4
============================================
Files 1 1
Lines 42 54 +12
============================================
+ Hits 36 48 +12
Misses 6 6
Continue to review full report at Codecov.
|
41b98bd
to
dab9d59
Compare
hello @hasanalibalcioglu, Yeap, I agree with you. This is a good option. I have thought about adding a new parameter to the method. Currently, the id parameter allows us to fetch a specific photo. The randomize argument append-only some random number to URL to prevent fetch image from a cache by a browser. If We add a new method, we don't need to check if the user provides randomize or static argument. This will be more clear for the user. We can move creating a query string to a separate method to prevent duplication. Also for static images, we don't need a randomize argument. |
20e2684
to
64892e2
Compare
Thank you for directives. As you can see i dont have much experience with tests and contributing. Is it ok now? |
1a64faa
to
83941d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ok, but Can you rename the method?
Thanks @hasanalibalcioglu |
I think its a good option to have :)