Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Sci_Position.h for N++ 8.2.2 #136

Merged
merged 1 commit into from Feb 3, 2022
Merged

update Sci_Position.h for N++ 8.2.2 #136

merged 1 commit into from Feb 3, 2022

Conversation

vinsworldcom
Copy link

@vinsworldcom vinsworldcom commented Feb 2, 2022

Just updated Sci_Position.h file to see if this fixes the issue.

Fix #135

@morbac morbac closed this Feb 3, 2022
@morbac morbac reopened this Feb 3, 2022
@morbac morbac merged commit 64e2d53 into morbac:master Feb 3, 2022
@morbac
Copy link
Owner

morbac commented Feb 3, 2022

I've included the fix in release 3.1.1.11.

@xomx
Copy link

xomx commented Feb 3, 2022

@morbac

This PR is incomplete. For your XMLTools plugin is not enough to update only the Sci_Position.h.

There are other problems in the plugin code in connection with the upcoming N++ 8.2.2+ support for 2GB+ files. One of them I mentioned here.

To reproduce the crash:

  • download a 8.2.2 RC5 x64 build of N++, e.g. this (edited: seems to this was deleted, so dl here instead)
  • add your latest patched 3.1.1.11 x64 plugin
  • start N++
  • open a 2GB+ text file (you can use e.g. this)
  • select menu Plugins -> XMLTools -> Pretty print
  • Plugin Crash msgbox: XMLTools.dll just crashed in runPluginCommand(size_t i : 36)

If you want to, I could tomorrow check the XMLTools plugin codebase for the remaining 2GB+ problematic parts and then create another PR to fix these problems.

@morbac
Copy link
Owner

morbac commented Feb 4, 2022

The fix embedded in 3.1.1.11 was required to avoid crash on "small" files.

Now I agree with you that this patch is by far not sufficient for 2GB+ files. I did some checks tonight and I think I could identify the crash root cause. I'll try to fix it as soon as possible.

@xomx
Copy link

xomx commented Feb 4, 2022

Ok. If you will need a tester, let me know.
There is also this N++ plugintemplate Scintilla.h update.
And thanks for your very useful plugin.

@morbac
Copy link
Owner

morbac commented Feb 5, 2022

Work is in progress. I've built this first pre-version of 3.1.1.12 which fix some issues you observed with 2GB+ files:

3.1.1.12 alpha.zip

I still have to improve error report when annotation mode is selected. I also have to check that modifications have not negative impact on encoding support.

@xomx
Copy link

xomx commented Feb 6, 2022

So far so good, no more crashing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sci_Position changes in upcoming Notepad++ 8.2.2 release
3 participants