-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New method for checking for new posts #68
Conversation
PR Summary
|
I did some testing myself but further thorough testing is needed. |
The marking posts as unread is quite a heavy load on the server. (Not sure if it's fixed in the newer version of phpbb). It's worth to eliminate it. Tested even more. Seems to me as perfectly good and ready to merge but would definitely benefit to have another pair of eyes reviewing it. |
i like the idea. Installed on my computer... now will see how it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! (I didn't even know till now that its reading and unreading...).
I have few comments though
Co-authored-by: חכם ממה נשתנה <94487951+chucem@users.noreply.github.com>
Co-authored-by: חכם ממה נשתנה <94487951+chucem@users.noreply.github.com>
so far It looks like it works great so far @mordechairoth is it possible to merge and publish? |
Restructured the way we look for new posts.
Instead of fetching the same page and then each time resetting the unread location, instead we fetch the 'forum' where this topic resides and then check the post count for the specific topic in question.
Included enhancements;
Future considerations: