Skip to content

Commit

Permalink
cleanup codes
Browse files Browse the repository at this point in the history
  • Loading branch information
philopon committed Jan 15, 2016
1 parent 9206f65 commit 2475021
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 34 deletions.
25 changes: 0 additions & 25 deletions mordred/_all.py

This file was deleted.

3 changes: 0 additions & 3 deletions mordred/_aromatic.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ class AromaticBondsCount(Descriptor):

def calculate(self, mol):
return sum(1 for b in mol.GetBonds() if b.GetIsAromatic())

_descriptors = [AromaticAtomsCount, AromaticBondsCount]
__all__ = [d.__name__ for d in _descriptors]
5 changes: 0 additions & 5 deletions mordred/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
from sys import maxint as maxsize


__all__ =\
'Calculator',\
'Descriptor',


class Key(object):
__slots__ = 'cls', 'args'

Expand Down
6 changes: 5 additions & 1 deletion mordred/_bcut.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ class BCUT(BurdenMatrixDescriptor):

@classmethod
def preset(cls):
return (cls(a, 1, h) for a in _atomic_property.get_properties(istate=True) for h in [False, True])
return (
cls(a, 1, h)
for a in _atomic_property.get_properties(istate=True)
for h in [False, True]
)

@property
def descriptor_name(self):
Expand Down
1 change: 1 addition & 0 deletions tests/test_WildmanCrippen.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from rdkit import Chem
from numpy.testing import assert_almost_equal


def test_WildmanCrippen1():
mol = Chem.MolFromSmiles('Oc1ccccc1OC')
yield assert_almost_equal, LogP('LogP')(mol), 1.4, 2
Expand Down

0 comments on commit 2475021

Please sign in to comment.