New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window tests are incomplete #654

Closed

6 tasks done

Orace opened this issue Nov 6, 2019 · 3 comments

Labels

Component-Tests

Contributor

Orace commented Nov 6, 2019 •

edited

Loading

Actually Window test doesn't cover

enumerator disposal (in Return isolated windows from Window* methods #655)
MoveNext calls after enumerator end (in Return isolated windows from Window* methods #655)
Returned Window are isolated from each others (see Windows of Window(Left|Right) are not isolated from each other #652) (in Return isolated windows from Window* methods #655)
Test Window method on known results (in Return isolated windows from Window* methods #655)
Test WindowLeft method on known results (in Refactor Window(Left|Right) #656)
Test WindowRight method on known results (in Refactor Window(Left|Right) #656)

Orace changed the title ~~Window tests don't cover enumerator diposal~~ Window are incomplete

Orace changed the title ~~Window are incomplete~~ Window tests are incomplete

Orace mentioned this issue

Improve Window tests #653

Closed

Contributor Author

Orace commented Nov 6, 2019 •

edited

Loading

All those tests are implemented in #653
They don't pass because of #652

Contributor Author

Orace commented Nov 6, 2019 •

edited

Loading

All those tests pass in #655

This was referenced Nov 6, 2019

Refactor Window(Left|Right) #656

Open

Return isolated windows from Window* methods #655

Merged

atifaziz added the Component-Tests label

Orace closed this as completed

Contributor Author

Orace commented Nov 21, 2019

Fixed with #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment