Review: MoreEnumerable.Partition()

[atifaziz]

Originally reported on Google Code with ID 44

Purpose of code changes on this branch:

Rev 128: Implementation of the Partition extension method, which transforms
a sequence into a series of sequences whose elements are defined by a set
of supplied partition sizes. Partition can be passed a projection function,
in which case the result is a sequence formed by first partitioning and
then transforming each partition into a result. An underflow strategy can
also be supplied, which control how partition behaves when there are
elements remaining in the source sequence after all explicit partitions
have been evaluated. Partition uses an unusual strategy for coping with
returning the "rest" of a sequence - it uses a special IEnumerable
implementation which caches the original enumerator.

When reviewing my code changes, please focus on:

* The public interface of the extension method.
* The effectiveness and clarity of the available XML comment documentation.
* How well this operator fits into the MoreLINQ ecosystem of
extension methods.
* The extent of coverage available from the corresponding unit tests.
* Whether edge cases are correctly identified and handled in the
implementation and tests.
* Whether the YieldRestEnumerator implementation is correctly implemented
and appropriately tested.
* Whether there is an easier way to deal with yielding the remainder of a
sequence, other than the YieldRestEnumerator approach.

After the review, I'll merge this branch into:
/trunk

Reported by ambientlion on 2010-01-18 17:38:40

[atifaziz]

Set review issue status to: Started

Reported by jojo.rudolph on 2010-04-10 11:20:02

• Status changed: Started

[atifaziz]

Now migrated to Hg and available in clone:
http://code.google.com/r/azizatif-morelinq-evenmore/
This clone is ready to be cloned :O) for further review. It also has the main/default
branch already merged in to bring it up to date.

Reported by azizatif on 2012-05-25 23:38:37

[atifaziz]

Following no response from ambientlion (who possibly/assuming lost interest given it
has taken years to get this far), taking ownership of issue to consider as addition
for MoreLINQ 2.0 milestone.

Reported by azizatif on 2013-06-12 22:10:51

• Labels added: Type-Enhancement, Priority-High, Milestone-Release2.0, Component-Logic
• Labels removed: Type-Review, Priority-Medium

[atifaziz]

This issue was closed by revision ecbb044b3f86.

Reported by azizatif on 2013-06-14 05:18:12

• Status changed: Fixed