Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: MoreEnumerable.Incremental() #46

Closed
atifaziz opened this issue Aug 21, 2015 · 6 comments
Closed

Review: MoreEnumerable.Incremental() #46

atifaziz opened this issue Aug 21, 2015 · 6 comments

Comments

@atifaziz
Copy link
Member

Originally reported on Google Code with ID 46

Purpose of code changes on this branch:

Rev 137: Implementation of the Incremental operator which visits each
adjacent pair of elements in a sequence: {N,N+1}, {N+1,N+2}, {N+2,N+3} ...
and applies a projection to them. An overload is available that is also
supplied the zero-based index of the *second* element in the pair. The
number of items in the result sequence will always be one less than in the
source. Incremental returns an empty sequence if passed a sequence of less
than two items. Incremental operates in a deferred, streaming fashion. 

When reviewing my code changes, please focus on:

* The public interface of the extension method.
* The effectiveness and clarity of the available XML comment documentation.
* How well this operator fits into the MoreLINQ ecosystem of
extension methods.
* The extent of coverage available from the corresponding unit tests.
* Whether edge cases are correctly identified and handled in the
implementation and tests.

After the review, I'll merge this branch into:
/trunk

Reported by ambientlion on 2010-01-23 17:16:35

@atifaziz
Copy link
Member Author

Now migrated to Hg and available in clone:
http://code.google.com/r/azizatif-morelinq-evenmore/
This clone is ready to be cloned :O) for further review. It also has the main/default
branch already merged in to bring it up to date.

Reported by azizatif on 2012-05-25 23:38:38

@atifaziz
Copy link
Member Author

Reported by azizatif on 2012-06-03 21:08:20

  • Status changed: Started

@atifaziz
Copy link
Member Author

Seems redundant with Pairwise.

Reported by azizatif on 2012-06-03 21:11:25

@atifaziz
Copy link
Member Author

Following no response from ambientlion (who possibly/assuming lost interest given it
has taken years to get this far), taking ownership of issue to consider as addition
for MoreLINQ 2.0 milestone.

Reported by azizatif on 2013-06-12 22:10:51

  • Labels added: Type-Enhancement, Priority-High, Milestone-Release2.0, Component-Logic
  • Labels removed: Type-Review, Priority-Medium

@atifaziz
Copy link
Member Author

This issue was closed by revision ecbb044b3f86.

Reported by azizatif on 2013-06-14 05:18:12

  • Status changed: Fixed

@atifaziz
Copy link
Member Author

Duplicate with Pairwise that was already published with release 1.0

Reported by azizatif on 2013-06-14 05:55:08

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant