Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binary files #16

Closed
jayvdb opened this issue Apr 28, 2018 · 10 comments
Closed

Allow binary files #16

jayvdb opened this issue Apr 28, 2018 · 10 comments
Assignees

Comments

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

Currently binary files cause an error.

They should be detected as non jinja, and copied to the source destination without being templated.

@chfw
Copy link
Member

chfw commented Apr 28, 2018

So you would like moban to copy files instead.

@jayvdb
Copy link
Member Author

jayvdb commented May 5, 2018

Yes.

Possibly these untemplated files could be listed in a different section instead of targets:?

@jayvdb
Copy link
Member Author

jayvdb commented May 7, 2018

maybe a new group called copy: ?

@jayvdb
Copy link
Member Author

jayvdb commented May 12, 2018

Also a copy could be used to copy templates from one repo to another repo, which cant be done atm because moban will apply the template .
i.e. https://gitlab.com/coala/mobans/issues/14

@chfw
Copy link
Member

chfw commented May 13, 2018

Accepted! Will use "copy:".

  1. copy is self-explanatory. cannot be more clearer
  2. copy: as separate, allows pain-free upgrade and incremental development.

@chfw chfw self-assigned this May 13, 2018
@chfw
Copy link
Member

chfw commented May 14, 2018

syntax:

copy:
  - "target file path": "source file path inside template directories"

example:

copy:
  - "moban/setup.py": setup.py

chfw added a commit that referenced this issue May 14, 2018
chfw added a commit that referenced this issue May 14, 2018
chfw added a commit that referenced this issue May 14, 2018
@jayvdb
Copy link
Member Author

jayvdb commented May 17, 2018

Another possible keyword instead of copy might be sync.

But copy is ok. I just thought of another possibility.

I see you've already done some work on this. I'll do some testing of this asap.

@jayvdb
Copy link
Member Author

jayvdb commented May 29, 2018

wfm

@jayvdb jayvdb closed this as completed May 29, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Jun 6, 2018

I just noticed that yehua uses configuration: static_path: and static:

Should these concepts be merged?

@chfw
Copy link
Member

chfw commented Jun 6, 2018

yeah, yehua needed it to copy over template, overlapping with moban's new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants