Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2 deprecation! #303

Closed
chfw opened this issue Jul 22, 2019 · 10 comments
Closed

python 2 deprecation! #303

chfw opened this issue Jul 22, 2019 · 10 comments

Comments

@chfw
Copy link
Member

chfw commented Jul 22, 2019

Shall we drop python 2 support beyond 2020?

@chfw
Copy link
Member Author

chfw commented Jul 22, 2019

related to #302, where python filesystem 2 demands unicode file path in python 2.

@chfw
Copy link
Member Author

chfw commented Jul 22, 2019

https://travis-ci.org/moremoban/moban/jobs/562319080

unicode break flake8

@chfw
Copy link
Member Author

chfw commented Jul 23, 2019

@chfw
Copy link
Member Author

chfw commented Jul 23, 2019

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.

@chfw
Copy link
Member Author

chfw commented Jul 26, 2019

GitPython requires Python '>=3.0, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 2.7.13

https://travis-ci.org/moremoban/moban/jobs/564152254

@chfw
Copy link
Member Author

chfw commented Jul 26, 2019

there are python 2 files for GitPython. So not sure why pypy2.7-6.0 would complain

https://pypi.org/project/GitPython/#files

@jayvdb
Copy link
Member

jayvdb commented Jul 27, 2019

We should cut a branch for Python 2 support and do a final release with Python 2 support, before removing support.

We can use multiple pins, like done with ruamel.yaml, to install older versions that support Python 2 only when required.

@chfw
Copy link
Member Author

chfw commented Jul 28, 2019

Please note this thread too: PyFilesystem/pyfilesystem2#317

@chfw
Copy link
Member Author

chfw commented Dec 28, 2019

this will be a priority in 0.7.0, in which python 3.7 only codes will be introduced, such as typing, f-string and data classes. multi-processing via asyncio are under consideration too.

@chfw chfw added this to in-progress in 0.7.x Dec 28, 2019
@jayvdb
Copy link
Member

jayvdb commented Dec 30, 2019

I dont see a problem with py27 deprecation.

If desupporting an old Python, please ensure that the setup.py uses python_requires so that users on other py versions can keep using the older versions of moban without disruption.

chfw added a commit that referenced this issue Jan 17, 2020
chfw added a commit that referenced this issue Jan 17, 2020
@chfw chfw closed this as completed Jan 17, 2020
chfw added a commit that referenced this issue Jan 18, 2020
@chfw chfw removed this from in-progress in 0.7.x May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants