Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage moban upstream repositories #35

Closed
jayvdb opened this issue Jun 5, 2018 · 7 comments
Closed

Manage moban upstream repositories #35

jayvdb opened this issue Jun 5, 2018 · 7 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jun 5, 2018

yehua has a key mobans which is uses to manage moban repositories.

This should be a feature of moban itself, as it is useful for other purposes.

@coala is already doing something similar, cloning the moban repo in CI and referring to it in the moban master file.

This then provides cookie-cutter like functionality.

@jayvdb
Copy link
Member Author

jayvdb commented Jun 5, 2018

@chfw
Copy link
Member

chfw commented Jun 5, 2018

yep, agree. moban should handle its own dependencies.

@chfw
Copy link
Member

chfw commented Jul 15, 2018

This will be a big step forward. Will get this in next release.

@chfw
Copy link
Member

chfw commented Jul 16, 2018

the naming convention will be:

All moban extensions will have moban as prefix, i.e. moban-mako, moban-haml ..

All moban templates(so called mobans) packages, will have mobans as suffix, i.e. pypi-mobans, pyexcel-mobans.

And there will be an exercise to convert all mobans repo as python packages. They include pypi-mobans, pyexcel-mobans, echarts-mobans, pypkg-mobans. And I will take care of coala-mobans when I will have covered all potential issues.

These converted packages will be acting as equivalent of cookie cutter packages. However, the difference will be: moban template packages are libraries, whereas cookie cutter packages are "executable" because cookie cutter will make scaffolding out from a single package. In order to cover this gap, it will make sense to include yehua related files with mobans so that, yehua could command yehua files and moban will take mobans as template libraries. For coala-mobans, I think I would better not to replace coala-quickstart with yehua file.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 8, 2018

As mentioned on #89, coala cant rely on pypi packages of coala-mobans .

We dont trust moban enhancements until they have used their enhanced template in other repos, so they must be able to build PRs referencing branches of the moban templates which are unmerged.

@chfw
Copy link
Member

chfw commented Aug 8, 2018

What about the following syntax (#89) for repo and pypi:

requires:
   pypi: 
     - pypi-mobans-pkg
   repo: 
     - https://github.com/moremoban/pypi-mobans
configuration:
  template_dir:
    - "pypi-mobans-pkg:templates" <-- this is how pypi is used
    - "pypi-mobans:templates" <-- this is how repo is used

@jayvdb jayvdb changed the title Manage moban repositories Manage moban upstream repositories Aug 9, 2018
@chfw
Copy link
Member

chfw commented Jan 13, 2019

I suppose this issue is resolved now.

@chfw chfw closed this as completed Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants