Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up errors when yaml is invalid #109

Closed
wants to merge 1 commit into from
Closed

Clean up errors when yaml is invalid #109

wants to merge 1 commit into from

Conversation

NNeast
Copy link

@NNeast NNeast commented Nov 2, 2018

This cleans errors when yaml file is invalid

Closes #37

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "black -l 79 on_your_changed_files.py"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?

This cleans errors when yaml file is invalid

Closes #37
Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests please.

Since there is big try catch in main function, do you still need the second one?

@chfw
Copy link
Member

chfw commented Nov 2, 2018

I will post a bit more comments after the unit tests are written.

@chfw
Copy link
Member

chfw commented Nov 3, 2018

Since there has been new changes in dev branch, please synchronise your fork.

@chfw chfw changed the base branch from master to dev November 13, 2018 18:23
@PrajwalM2212
Copy link
Collaborator

PrajwalM2212 commented Dec 2, 2018

Closing this PR as #139 solves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants