Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitfs2 - the final syntax for repo #312

Merged
merged 18 commits into from
Aug 16, 2019
Merged

gitfs2 - the final syntax for repo #312

merged 18 commits into from
Aug 16, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Aug 13, 2019

the follow-up PR for #302. Here is the updated and final syntax:

Here are the sample file::

    configuration:
      template_dir:
        - "git://github.com/moremoban/pypi-mobans.git!/templates"
        - local
      configuration: config.yml
      configuration_dir: "git://github.com/moremoban/pypi-mobans.git!/config"
    targets:
      - mytravis.yml: travis.yml.jj2
      - test.txt: demo.txt.jj2

The sumodule syntax is::

    configuration:
      template_dir:
        - "git://github.com/moremoban/pypi-mobans.git?submodule=true&branch=your_choice_or_default_branch_if_not_specified!/templates"
        - local

If you have reference instead of branch::

    configuration:
      template_dir:
        - "git://github.com/moremoban/pypi-mobans.git?submodule=true&reference=your_alternative_reference_but_not_used_together_with_branch!/templates"
        - local

And requires is now officially deprecated.

@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #312 into dev will decrease coverage by 0.98%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #312      +/-   ##
==========================================
- Coverage   98.78%   97.79%   -0.99%     
==========================================
  Files          61       59       -2     
  Lines        2882     2817      -65     
==========================================
- Hits         2847     2755      -92     
- Misses         35       62      +27
Impacted Files Coverage Δ
moban/utils.py 97.29% <ø> (-0.21%) ⬇️
moban/definitions.py 100% <ø> (ø) ⬆️
moban/main.py 100% <ø> (ø) ⬆️
moban/deprecated/repo.py 63.82% <ø> (ø)
moban/mobanfile/__init__.py 99.25% <100%> (ø) ⬆️
tests/mobanfile/test_mobanfile.py 100% <100%> (ø) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
tests/test_utils.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
tests/test_definitions.py 100% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a3826...4236739. Read the comment docs.

@chfw chfw changed the title gitfs2 - the final syntax for repo (DNM) gitfs2 - the final syntax for repo Aug 14, 2019
@chfw chfw merged commit 8815f7a into dev Aug 16, 2019
@chfw
Copy link
Member Author

chfw commented Aug 16, 2019

Please give your feedback when it is going to be released then. The development needs to go forward.

@chfw
Copy link
Member Author

chfw commented Aug 17, 2019

@jayvdb , before PyFilesystem 2 take my PR, you can still give feedback so as to change its behavior.

@chfw chfw deleted the gitfs2 branch August 19, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants