Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt_in] Tiny improvements to make exporting easier. #265

Merged
merged 4 commits into from Jan 29, 2021
Merged

Conversation

torotil
Copy link
Contributor

@torotil torotil commented Jan 23, 2021

A few tiny improvements that are needed for moreonion/campaignion_logcrm#12

This doesn’t hurt and makes adding additional info based on the
component a lot easier.
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #265 (2329494) into 7.x-2.x (a20df7e) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             7.x-2.x     #265      +/-   ##
=============================================
+ Coverage      46.18%   46.33%   +0.14%     
- Complexity      1878     1880       +2     
=============================================
  Files            288      288              
  Lines          10162    10192      +30     
  Branches         154      154              
=============================================
+ Hits            4693     4722      +29     
- Misses          5466     5467       +1     
  Partials           3        3              
Impacted Files Coverage Δ Complexity Δ
campaignion_opt_in/campaignion_opt_in.module 91.52% <100.00%> (+0.29%) 0.00 <0.00> (ø)
campaignion_opt_in/src/Values.php 99.01% <100.00%> (ø) 44.00 <0.00> (ø)
src/CRM/Import/Field/BooleanOptIn.php 68.75% <0.00%> (-9.83%) 8.00% <0.00%> (ø%)
src/CRM/Import/Field/Address.php 94.73% <0.00%> (+3.43%) 38.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20df7e...2329494. Read the comment docs.

@torotil torotil changed the title [opt_in] Values: Use $component['cid'] as key for value arrays. [opt_in] Tiny improvements to make exporting easier. Jan 27, 2021
@torotil torotil merged commit ba2ab30 into 7.x-2.x Jan 29, 2021
@torotil torotil deleted the optin-cids branch January 29, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants