Bundle Vue apps with Vite instead of Webpack #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.x-2.x #313 +/- ##
============================================
- Coverage 4.98% 4.14% -0.84%
Complexity 1947 1947
============================================
Files 306 269 -37
Lines 13083 12038 -1045
Branches 154 0 -154
============================================
- Hits 652 499 -153
+ Misses 12428 11539 -889
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. |
mayakokits
force-pushed
the
vue-apps-vite
branch
4 times, most recently
from
abe58b3
to
f716568
Compare
torotil
requested changes
Mar 13, 2023
torotil
requested changes
Mar 13, 2023
- Get rid of campaignion_vue, import dependencies directly - Update vue to 2.7.7 - Build with Vite 3.2.4 instead of Webpack - Run unit tests with Vitest - Use Nightwatch 1.7.13 for end to end testing - Update some dependencies: axios, element-ui, popper.js, vue-tables-2, vuedraggable
- Get rid of campaignion_vue, import dependencies directly - For simplicity, copy DestinationField component and utils into this project - Update vue to 2.7.7 - Build with Vite 3.2.4 instead of Webpack - Run unit tests with Vitest - Update some dependencies: axios, element-ui, vuedraggable
- Build with Vite 3.2.4 instead of Webpack - Get rid of campaignion_vue, import dependencies directly - For simplicity, copy DestinationField component and utils into this project - Update vue to 2.7.7 - Update some dependencies: axios, element-ui, vuedraggable - Run unit tests with Vitest - Use Nightwatch 1.7.13 for end to end testing
- update eslint to support import.meta - update eslint plugins - update eslint config - add script to run eslint --fix - adapt code to comply with the rules
mayakokits
force-pushed
the
vue-apps-vite
branch
from
0af5d56
to
9b65c1e
Compare
- don't provide a Node module any more - remove dependencies, they are now bundled with the apps - adapt Drupal module - update README
|
Now the |
mayakokits
changed the title
- use the el-button notation throughout the datasets app - remove invalid type="button" attribute - add strings to drupal fixtures so they don't throw in dev env - build all apps
mayakokits
force-pushed
the
vue-apps-vite
branch
from
0bd265d
to
b316683
Compare
torotil
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Webpack with Vite 3 for the Vue apps in e2t, update Vue and some dependencies. Dependencies are bundled with the apps, not used via
campaignion_vueany more.