Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation flag removal for usurping and reforming formables #146

Open
rogerburks opened this issue Feb 18, 2022 · 1 comment · May be fixed by #149
Open

Formation flag removal for usurping and reforming formables #146

rogerburks opened this issue Feb 18, 2022 · 1 comment · May be fixed by #149
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rogerburks
Copy link
Collaborator

rogerburks commented Feb 18, 2022

I have started a project to provide decisions for allowing, probably usually the player, to re-form cultural union tags for instance: re-forming Yugoslavia if they can annex it and fit the normal requirements. My idea for this is, if one is very close to a formable, it should not be prevented if another tag simply has a much easier path to it.

However, I believe that the formable itself must be annexed before this is made possible, so that the process is challenging but remains possible. A scenario would be: Someone is playing as Montenegro and is close to forming Yugoslavia, but Serbia outraces them. If Montenegro can annex Yugoslavia, it can then remove the flag yugoslavia_formed and can then reform Yugoslavia.

I have made a new decisions file, cch.various.txt to house small decisions like this, to avoid keeping them in older HFM files. The localization will be stored in cch.fixes.csv.

I think it could also be possible for me to include fixes suggested in #81 in this project as well.

@rogerburks rogerburks self-assigned this Feb 18, 2022
@rogerburks rogerburks added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2022
@rogerburks rogerburks changed the title Flag removal for usurping and reforming formables Formation flag removal for usurping and reforming formables Feb 18, 2022
@rogerburks
Copy link
Collaborator Author

rogerburks commented Feb 18, 2022

So far a list of tags investigated:

  • Germany: Does not need this. You can already annex Germany, then become either the NGF or SGF and then become Germany.
  • Italy: Does not need this. You can already annex Italy and re-form it.
  • Scandinavia: This now works, although it is good to know that in abolishing Scandinavia, I temporarily remove SCA cores from Schleswig-Holstein, to make formation fair. They return once you form Scandinavia again. It will not work if you remove all SCA cores everywhere, since that breaks the allow of form_scandinavia. Additionally, if a tag gains leader_of_kalmar, it does not block anything, since there is a decision usurp_kalmar to take this flag away from the current leader. It requires that they are not a great power anymore but your tag is.
  • Yugoslavia: Fix works.
  • Transcaucasia: same fix applied as in Yugoslavia
  • Turkestan: same fix applied as in Yugoslavia

Others which may require different fixes:

  • Indonesia: I suggest providing a separate decision for Indonesian tags to use after organization.
  • Yemen: I think (I may be wrong) that I have this covered in Aden protectorate formation modified #111 , but if not, I can address this later.
    - Tukulor Empire: Does not need this. You can already annex it and reform it. Incorrect. This can be fixed with a simple edit (which is done in the associated pull request).
  • Ethiopia: Does not need this. You can already annex it and reform it.
  • Arabia: It may need a fix to return cores, although I am not sure there is a use case for it. It seems like the Arab Union is probably well within reach by that point.
  • Malaysia, Laos, and some others: Since the ai does not normally form these, I do not plan to suggest fixes for them (and they may not need fixes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant