Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropped columns from FREE df that are not required #80

Merged
merged 1 commit into from Jan 24, 2023
Merged

dropped columns from FREE df that are not required #80

merged 1 commit into from Jan 24, 2023

Conversation

bomtuckle
Copy link
Contributor

@bomtuckle bomtuckle commented Jan 10, 2023 •
edited by morganjwilliams

Description

Dropped the components that are summed to form FREE_O in the FREE df, as they are not required and were being returned

Related Issue

#53

Motivation and Context

removes unnecessary outputs from norm function

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@morganjwilliams
Copy link
Owner

Hey @bomtuckle! Thanks for this one, I'll merge it in. Apologies for the delay, I've been travelling.

@morganjwilliams morganjwilliams merged commit 6ecb02d into morganjwilliams:feature/CIPW-output-update Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bomtuckle @morganjwilliams