Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cipw output update #87

Merged

Conversation

bomtuckle
Copy link
Contributor

@bomtuckle bomtuckle commented Jul 18, 2023

Description

Some more minor corrections to the norm calculation. Main issue was that SO3 was not getting converted to moles.

Related Issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bomtuckle
Copy link
Contributor Author

@morganjwilliams - sorry for the addtional PR. I found some further issues.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5589696941

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 90.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyrolite/mineral/normative.py 8 9 88.89%
Totals Coverage Status
Change from base Build 5583462154: 0.001%
Covered Lines: 5980
Relevant Lines: 6614

💛 - Coveralls

@morganjwilliams
Copy link
Owner

@bomtuckle no worries, incremental PRs are also welcome. I'll leave this one open for today in case there are any new things which pop up, and will plan to merge it in tomorrow.

@morganjwilliams morganjwilliams merged commit 95bf787 into morganjwilliams:develop Jul 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants