Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match sdk version on start of string to ignore preview versions #78

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

bingenito
Copy link
Member

@bingenito bingenito commented Mar 2, 2024

Change regex to skip substring match of ".23624.5" of the preview release which is an invalid Version().

3.1.426 [C:\Program Files\dotnet\sdk]
5.0.408 [C:\Program Files\dotnet\sdk]
6.0.321 [C:\Program Files\dotnet\sdk]
8.0.200-preview.23624.5 [C:\Program Files\dotnet\sdk]

@psmulovics psmulovics merged commit 08e7baf into morganstanley:main Mar 2, 2024
2 checks passed
@bingenito bingenito deleted the sdk-regex branch March 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants