Fix/certain assertions in wrong place in split-exported JSON #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyifan
requested changes
May 22, 2024
| @@ -0,0 +1 @@ | |||
| Fix an issue in JSON exporter which puts assertions from synthesized cases in the wrong data structure. | |||
There was a problem hiding this comment.
Fix the issue that assertions in synthesized testcase (setup/teardown etc.) are not rendered on UI report.
| # FIXME: | ||
| # with ReportCategories.SYNTHESIZED being added, following line is no longer | ||
| # able to tell testcase entries from assertion entries; while filtering has | ||
| # been properly done in frontend code, it should just work in production |
There was a problem hiding this comment.
It seems frontend sends testcase report with entries (and garbage data) when filter is applied.
So you may go recursive into the garbage data when entry is a synthesized testcase level report.
zhenyu-ms
force-pushed
the
synthesized-reports-cont
branch
from
8dc5116
to
ee310b8
Compare
Pyifan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Clearly and concisely describe the problem.
Solution description
Describe your code changes in detail for reviewers.
Checklist: