Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not propagate to root logger from report.logger #1087

Merged
merged 2 commits into from
May 24, 2024

Conversation

kn-ms
Copy link
Contributor

@kn-ms kn-ms commented May 23, 2024

Bug / Requirement Description

The report logger is a child of the root logger currently. Normally the root logger does not have any handler in tp runs, so any log meant to the report is not logged to the logfile/stdout.

It could happen that a user or other libraries sets up root logger to emmmit logs to stdout/stderr so report logs appear there as well, causing noise.

Solution description

Do not propagate from report logger to the root logger

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@kn-ms kn-ms requested a review from a team as a code owner May 23, 2024 14:53
yuxuan-ms
yuxuan-ms previously approved these changes May 24, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name should be 2882_changed.no_report_log_propagation.rst

@yuxuan-ms yuxuan-ms self-requested a review May 24, 2024 02:56
@kn-ms kn-ms merged commit 89e23dc into morganstanley:main May 24, 2024
15 checks passed
@kn-ms kn-ms deleted the report_logger_no_propagate branch May 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants