Fix Newly created worker may raise when pool is exiting #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoyitao
force-pushed
the
fix_pool_exit_msg
branch
3 times, most recently
from
8b52aef
to
6dfb3cc
Compare
* A worker communicates with its parent, sending a message and get the response. When a worker is created, e.g. unexpectedly abort and then re-created, it should receive a `ConfigSending` message, but if at this point all task is finished then an `Stop` message arrives, there will be stack information of error logged, which might lead to misunderstanding. * Fix a log message which is not correctly formatted during handling inactive workers.
raoyitao
force-pushed
the
fix_pool_exit_msg
branch
from
6dfb3cc
to
13f139d
Compare
Pyifan
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response. When a worker is created, e.g. unexpectedly abort and then
re-created, it should receive a
ConfigSendingmessage, but if atthis point all task is finished then an
Stopmessage arrives, therewill be stack information of error logged, which might lead to
misunderstanding.
inactive workers.