Using the download (-d) option doesn't actually download firmware updates

[morgant]

For some reason, the -d (download) option doesn't actually download firmware and instead calls fw_update -n, which is dry-run mode. That lists the firmware that would be installed, but doesn't download anything.

It'd be preferable if it used fw_update -F ${some_path}, which will download firmware from the default URL to the ${some_path} directory. I'm not sure if we want to put that in a subdirectory of /tmp (with root-only permissions, of course) or something like /home/_swupdate/ (like sysupgrade does with /home/_sysupgrade/). I'm leaning toward the latter as it'd be preserved across reboots.

Of course, if we do that, we should probably also then update the -i (install) option to download firmware to and install it from /home/_swupdate/ (or whatever directory we end up using) with fw_update -p ${some_path}.

[morgant]

I've started this and added a swupdate -b option (like sysupgrade(8); defaults to /home/_swupdate) and download_firmware() & install_firmware() functions which will download firmware to it and install from it, respectively.

Needs more testing, especially whether it's redownloading the firmware files each time. Also, what if one wants to install firmware that has already been downloaded, but not try to refetch them again first?

[morgant]

I haven't looked at the fw_update(8) source yet, but in my testing, it:

• Does not redownload firmware files to the base directory if the same version already exists in the base directory
• If a firmware file is deleted from the base directory, it will redownload only that one file to the base directory

So, it seems to do everything I'd hoped and doesn't really need any additional work on my end to handle those situations. Yay!