Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16-bit color codes inverted in light mode demo palette #146

Closed
gotgenes opened this issue Nov 10, 2016 · 1 comment
Closed

16-bit color codes inverted in light mode demo palette #146

gotgenes opened this issue Nov 10, 2016 · 1 comment

Comments

@gotgenes
Copy link

gotgenes commented Nov 10, 2016

Based on the X-term color codes shown here, and based off the usage of colors in Vim, the color codes associated with the colors in the light mode demo palette shown on gruvbox's README/main project page are inverted:

Palette Light

There are two inversions that occurred:

  1. For every column in the first two rows, the positions and 16-bit numbers need to be swapped. For example, currently "red #cc241d" is marked as Xterm color 1 and "red #9d0006" is marked as Xterm color 9. However, in Vim, "red #9d0006" is actually used as the "normal" red (which is Xterm color 1), and "red #cc241d" is used as the "bright" red (Xterm color 9). To fix this, swap the colors of the first two rows but, keep the 16-bit numbers in place.
  2. The first column (bg #fbf1c7 and gray #928374) last columns (gray #7c6f64 and fg #3c3836) are also inverted. 0 and 8 are for black and dark gray, respectively, while 7 and 15 are for light gray and white, respectively. To fix this, swap the first two rows of the first and last columns, keeping the 16-bit numbers in place.

Additionally, the 0* needs to be updated to be 15*, instead.

@morhetz
Copy link
Owner

morhetz commented Dec 22, 2016

Nope, sorry. That was intended behaviour to balance light mode since X-term colors are based on black bg
As far as light mode means light bg it needs to be inverted

@morhetz morhetz closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants