Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell highlighting is broken #190

Open
hadronized opened this issue Aug 17, 2017 · 7 comments
Open

Haskell highlighting is broken #190

hadronized opened this issue Aug 17, 2017 · 7 comments

Comments

@hadronized
Copy link

I had to remove the overridings from gruvbox to get a decent syntax highlighting back. There’s some kind of regression. Is there a way to fix that?

@morhetz
Copy link
Owner

morhetz commented Aug 17, 2017

elaborate please

@hadronized
Copy link
Author

Yeah, sorry. I’ll try to provide a screenshot different when I meet enough spare time. The issue is that, now, for instance, the signature functions are like plain text, they don’t even have colors any more. And it’s the same for most common Haskell constructs, like operators.

@Adaephon-GH
Copy link

I ran into the same issue and did some digging. It seems that the cause for the broken (or only partially working) highlighting is that Gruvbox does not link to the default highlighting group names.

In the haskell syntax definition that is included with vim and nvim ($VIMRUNTIME/syntax/haskell) every group name starts with hs followed by the appropriate specifier. For example hsString, hsCharacter, hsOperator. Whereas the groups linked to by Gruvbox have the prefix haskell, for example haskellString, haskellChar, haskellOperators.

It seems to me that, when writing the highlighting for Haskell, some other plugin was active that changed the syntax definition for Haskell. One candidate might be haskell-vim as using it indeed improves highlighting with Gruvbox.

@morhetz
Copy link
Owner

morhetz commented Oct 2, 2017

@Adaephon-GH https://github.com/sheerun/vim-polyglot is the base syn package for modern vim
so, yeah it's https://github.com/neovimhaskell/haskell-vim

@hadronized
Copy link
Author

Is there any leads to fix that problem? I might switch to a fork until it gets fixed (why overriding the syntax hilighting in the first place?)

hadronized added a commit to hadronized/gruvbox that referenced this issue Nov 11, 2017
@hovsater
Copy link

@morhetz any update here?

@mitchellwrosen
Copy link

I agree syntax highlighting looks a bit bland in Haskell, but I'm not sure I understand the explanation above, nor the fix merged into gruvbox-community.

Looking at the syntax definition in gruvbox, both haskellIdentifier and haskellType are defined as GruvboxFg1. The result is a lot of white where perhaps some more color would look nicer. Here's a random example screenshot:
2020-09-08-100916_1919x1059_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants