Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursorline not highlighting "Operator" syntax group #260

Open
kakig opened this issue Jan 24, 2019 · 11 comments
Open

cursorline not highlighting "Operator" syntax group #260

kakig opened this issue Jan 24, 2019 · 11 comments

Comments

@kakig
Copy link

kakig commented Jan 24, 2019

2019-01-24-132226_339x67_scrot
The '=' isn't highlighted by cursorline.
I investigated and found this:

hi! link Operator Normal

call s:HL('Normal', s:fg1, s:bg0)
The syntax is setting the background back to bg0.
Don't know if it is intended behaviour but I find it very distracting sometimes.
Edit: typo.

@ronisbr
Copy link

ronisbr commented Mar 29, 2019

I am also seeing this. Is there any workaround at the moment?

@loyd
Copy link

loyd commented May 10, 2019

The same is true in case of floating windows:
2019-05-10_20-40-12

Workaround: replace Normal with GruvboxFg1:
2019-05-10_20-40-26

Sadly, resetting (hi! link Operator GruvboxFg1) in .vimrc doesn't fix all cases, need to fix the original line.

@chaudry-786
Copy link

Any fix for this? I still have the issue in Neovim.
gruvbox

@lucalaissue
Copy link

Has anyone found a workaround for this ? Also having that issue

@chaudry-786
Copy link

in file ~/.vim/plugged/gruvbox/colors/gruvbox.vim change line 591 to hi! link Operator GruvboxFg1

@vhoyer
Copy link

vhoyer commented Nov 22, 2022

can't we just remove the s:bg0 out of the call s:HL('Normal', s:fg1, s:bg0), that way the 'Normal' would be defined without a background and I assume this wouldn't be a problem anymore

@vhoyer
Copy link

vhoyer commented Nov 22, 2022

or rather, I'm not even having this problem anymore, can anyone confirm that this is still a problem, and if it is provide a minimal reproduction to this issue? if you need a model, you probably can use this one I made as an example: https://github.com/vhoyer-bug-reproductions/airline-freeze-on-C-c

@kakig
Copy link
Author

kakig commented Nov 24, 2022

@vhoyer Here is the minimal example: https://github.com/kakig/gruvbox-cursorline-hightlight-bug

In the second line of the vimrc you can still see the bug happening:
image

@vhoyer
Copy link

vhoyer commented Nov 24, 2022

well, as pointed out the the OP, the problem is in the Normal highlighting group and so it happens whenever this group is linked to another things, for example in a vim file, the highlighting for the vimUserFunc group which also is linked to Normal has the same problem.

so what has worked for me as a workaround is defining after the colorscheme gruvbox:

highlight Normal guibg=NONE ctermbg=NONE

vhoyer added a commit to vhoyer/gruvbox that referenced this issue Nov 24, 2022
vhoyer added a commit to vhoyer/gruvbox that referenced this issue Nov 24, 2022
@vhoyer
Copy link

vhoyer commented Nov 24, 2022

Turns out setting this hihglight rule I pointed as a workaround, messes with the airline coloring, so, use at your own risk ahah

@vhoyer
Copy link

vhoyer commented Nov 24, 2022

if the problem is exclusively with the operator you can always just

hightlight Operator ctermbg=NONE guibg=NONE

haven't test this tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants