Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compose to 1.5.3 #198

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Update compose to 1.5.3 #198

merged 1 commit into from
Oct 22, 2023

Conversation

mataku
Copy link
Contributor

@mataku mataku commented Oct 14, 2023

Changes

resolves #197

  • Update compose to 1.5 stable
  • Update compileSdk to 34
    • emoji2 helper which is a dependency of compose requires compile SDK 34, so updated to pass build
  • Update compose compiler to 1.5.3, kotlin to 1.9.10

@mataku
Update to Compose 1.5.3
04fc2aa 
Compile sdk version 34 is required for Compose 1.5 dependency
@mataku mataku marked this pull request as ready for review October 14, 2023 13:55
mori-atsushi
mori-atsushi approved these changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@mori-atsushi mori-atsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@mori-atsushi mori-atsushi merged commit 424b818 into mori-atsushi:main Oct 22, 2023
1 check passed
@mataku mataku deleted the feature/compose-1.5 branch October 24, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mori-atsushi mori-atsushi mori-atsushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes with Compose 1.5.X
2 participants
@mataku @mori-atsushi