Always allow interrupt when initiated by a change in session expiry date from another tab #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate from another tab
|
A bit more info... I have an app with autoResume set to 'notIdle', as I want the user to click a button to remain logged in. However, if I have multiple tabs open and choose to remain logged-in in one, then the Idle.interrupt(true) fired in the hidden browser tab does not subsequently call Idle.watch(true), which I think it should always do if initiated from another tab. The results is that currently the hidden tab will log the user out, even if the they choose to remain logged in on the active tab. This pull request should fix it. |
|
Yeah, I didn't think this was necessary at first but I get it now.
|
|
Also thanks for your contributions! |
moribvndvs
added a commit
that referenced
this pull request
Dec 8, 2015
…rom_another_tab Always allow interrupt when initiated by a change in session expiry date from another tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.