Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import 'zone.js' which may cause duplicate , zone already exist error … #103

Closed
wants to merge 1 commit into from

Conversation

richie50
Copy link

…fixed and code updates to reflect angular 6.0.3 (current release)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…fixed and code updates to reflect angular 6.0.3 (current release)
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.376% when pulling b4c1bc6 on richie50:dev-richie-ng2-idle into 511ee8b on HackedByChinese:master.

@nallarv
Copy link

nallarv commented May 31, 2018

Looks good. When does this PR get merged?

@moribvndvs
Copy link
Owner

The most important change is removing the extraneous zone.js import. I'm not sure about your changes for RXJS imports. They don't match the docs from Angular or RXJS. I did go ahead with another change to remove the need for rxjs-compat.

@moribvndvs moribvndvs closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants