Return bool from XXXOf functions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 95.88% 95.91% +0.03%
==========================================
Files 5 5
Lines 267 269 +2
==========================================
+ Hits 256 258 +2
Misses 7 7
Partials 4 4
Continue to review full report at Codecov.
|
true if data exists, false if no data exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
XXXOf functions also return bool value.
Return true if data exists, false if no data exists.
Affected functions.
CodeOfMessageOfCallStackOfThis PR breaks backward compatibility.
Motivation
Enforce checking zero value.
For now, If we call XXXOf functions like
CodeOf(err).ErrorCode(), It can panic!!By adding bool into its returning value, developers must consider zero value.