Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 release #42

Merged
merged 9 commits into from Apr 22, 2022
Merged

v1 release #42

merged 9 commits into from Apr 22, 2022

Conversation

morikuni
Copy link
Owner

@morikuni morikuni commented Mar 4, 2022

Changes

  • Removed deprecated symbols.

Motivation

  • Since failure has been stable for more than 1 year, assuming no need to make breaking changes anymore.

Migration Guideline

For almost all use-cases only following change may be required.

  • Replace codes that converts errors into interface{ GetXXX() YYY } (e.g. v, ok := err.interface{ GetCode() failure.Code }) with iterator.As(&v) (e.g. var c failure.Code; iterator.As(&c)).

If you're not customizing the failure, just using some functions, then you don't need to worry too much about v1 release.

@codecov-commenter
Copy link

Codecov Report

Merging #42 (bb62203) into master (b813ae7) will increase coverage by 5.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   90.44%   95.46%   +5.02%     
==========================================
  Files           6        6              
  Lines         293      353      +60     
==========================================
+ Hits          265      337      +72     
+ Misses         24       10      -14     
- Partials        4        6       +2     
Impacted Files Coverage Δ
failure.go 100.00% <ø> (+17.64%) ⬆️
wrapper.go 97.36% <ø> (+3.66%) ⬆️
iterator.go 100.00% <100.00%> (ø)
code.go 100.00% <0.00%> (ø)
tracer.go 96.29% <0.00%> (+0.64%) ⬆️
callstack.go 83.82% <0.00%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b813ae7...bb62203. Read the comment docs.

@morikuni morikuni changed the title v1 release candidate v1 release Mar 5, 2022
for backward compatibility
@morikuni morikuni merged commit 0148d85 into master Apr 22, 2022
@morikuni morikuni deleted the v1-release branch April 22, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants