-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: RML-star - multiple predicate-object-mappings not recognised in base of 2nd-level deeply nested triples #174
Comments
Hi @pawelostr , I just tried your example with Morph-KGC v 2.4.0 and with the latest version available in the repository and it is working correctly generating all the triples. I am on Ubuntu. CI test cases pass on python 3.11 and MacOS. I wonder if it could be your MacOS version. Please try on another OS. Julián |
Hi Julián, So I've tried the mappings on Windows 11 22H2 with Python 3.9.13 and in Google Colab, and unfortunatelly the result it still the same - no triples from Below is a script for Colab, in which exactly 0 triples are generated, as to exacerbate the problem I've switched
On a side note, I've tried almost every combination of NonAssertedTriplesMap, AssertedTriplesMap, TriplesMap, and all the combinations of prefixes from RML and R2RML to no avail. Edit: So I also tested it on up-to-date Arch with python 3.11.3 in conda env on 2.5.1, and again only inner and mid triples are generated. |
Hi @pawelostr , I tried again and it is working. Julián |
Hi @pawelostr, @arenas-guerrero-julian, I've tried with the example provided and it is a mistake in the mapping, morph works fine. With the attached mapping and v2.6.0 I get as result nested quoted triples. |
Thanks for checking this @anaigmo |
Hey @anaigmo @arenas-guerrero-julian, There was indeed an error in my original example, as I've mixed some old and new stuff, and @anaigmo 's works in both 2.5.1 and 2.6.0. For posteriority I'll leave a modified one that's fully on |
Test cases for issue #174
This issue is related to #124 |
Unfortunately the original diagnosis (#174 (comment)) was wrong, and uploaded example mapping was not representative of the issue at hand.
only the second part is the problem, first is a problem of incorrect mappings that have been created during attemps at diagnosis of the bug. What Happens?If a second level of deeply nested quoted triples is attempted to be generated ( To ReproduceRun test/issues/issue_174 (tests a and b will fail, c will pass) on a pre-pull request no 177 (<=2.6.0) morph-kgc. ResolutionPull request no. 177 fixes described problem and 178 adds additional tests. |
What Happens?
See #174 (comment)
When attempting to generate any kind of 2nd level quote the engine fails (producing no double quoted triples most of the time, in some cases there will be one triple generated).To Reproduce
Use the files in following Gist mapping and data source - this is an example adopted from RML-star spec, where no 2nd level quoted triples are generated.Same problem happens with XML files and appropiate mappings.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: