fix(vstateselect): avoid mutating 'items' prop

Avoid direct mutation of the 'items' prop
morphatic · Sep 8, 2019 · 36aac5e · 36aac5e
1 parent f7c7ef1
commit 36aac5e
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/VStateSelect.ts b/src/VStateSelect.ts
@@ -24,10 +24,6 @@ interface options extends InstanceType<typeof base> {
    * about here.
    */
   foo: string
-  /**
-   * !Props inherited from VAutocomplete
-   */
-  items: Object[]
 }
 // Extend VAutocomplete to define the VStateSelect component
 export default base.extend<options>().extend({
@@ -41,14 +37,16 @@ export default base.extend<options>().extend({
   data: () => ({
     usaStates: new UsaStates(),
   }),
-  computed: {},
-  watch: {},
-  mounted () {
-    this.items = this.usaStates.format({
-      $text: 'name',
-      $value: 'abbr',
-    })
+  computed: {
+    allItems (): object[] {
+      return this.usaStates.format({
+        $text: 'name',
+        $value: 'abbr',
+      })
+    },
   },
+  watch: {},
+  mounted () {},
   methods: {
     bar () {
       return 'baz'