Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdivx provider not working in 1.4.2-beta.6 #2395

Closed
avraham opened this issue Feb 17, 2024 · 7 comments
Closed

Subdivx provider not working in 1.4.2-beta.6 #2395

avraham opened this issue Feb 17, 2024 · 7 comments

Comments

@avraham
Copy link

avraham commented Feb 17, 2024

Describe the bug
Subdivx provider doesn't find subtitles.
Subdivx recently revamped their website, but I installed v1.4.2-beta.6, on which it should be working, but it doesn't.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a movie and manually search for subtitles.
  2. No subtitles are found and there are error messages in the logs. While there are subtitles in the website.

log file
bazarr (1).log

Expected behavior
Find the subtitle

Screenshots
Screen Shot 2024-02-16 at 4 58 54 PM

Software (please complete the following information):

  • Bazarr: Linuxserver.io version:- v1.4.2-beta.6-ls574 Build-date:- 2024-02-16T06:29:02+00:00
  • Radarr version 5.2.6.8376
@morpheus65535
Copy link
Owner

Should be fixed in upcoming beta.7. Can you confirm please?

@avraham
Copy link
Author

avraham commented Feb 17, 2024

Sure. I'll test it in the next beta release.
Thank you.

@rmichelena
Copy link

rmichelena commented Feb 17, 2024

@avraham , as you can see in the logs it's HTTP error 500 - it's an internal server error, it comes from Subdivx and it's transient. I've just tried and seems to work fine.
Try again and let us know.

@rmichelena
Copy link

I stand corrected. The matter is that there's an alternate title in Korean ; the request breaks Subdivx. If you try to search "플레이어스|" (that's the alternative title) in Subdivx's website UI, it hangs forever.
As it does not make sense to search non-latin character encodings in Subdivx, I'll try to add some code to detect and drop those alternate titles.

@morpheus65535
Copy link
Owner

@rmichelena my latest fix return [] on 500.

@rmichelena
Copy link

Ok, done ; tested with "Isle of Dogs (2018)" which has alternative titles in a lot of languages. Works ok.
I've forked and created a pull request, hope it's done correctly, first time contributing to a project :)

@rmichelena
Copy link

rmichelena commented Feb 17, 2024

@morpheus65535 sorry didn't see your fix on time. Mine works differently, just avoids querying with titles that contain non-allowed characters (in allowed I include all European diacriticals too, and the German ß) - basically eliminating the Korean, Japanese, Russian, Chinese, Hindi, etc. that will break Subdivx.

I've merged your solution and mine ; because it might still happen that it'd return 500, but also it's better (and faster) to reduce queries (specially troublesome queries) to the provider. So my pull request is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants